Re: [PATCH v2 net-next 1/5] dsa: add support for Microchip KSZ tail tagging

[Andrew Lunn]

On Fri, May 12, 2017 at 08:07:54PM +0000, woojung....@microchip.com wrote:
> +     padlen = (skb->len >= ETH_ZLEN) ? 0 : ETH_ZLEN - skb->len;
> +
> +     if (skb_tailroom(skb) >= padlen + KSZ_INGRESS_TAG_LEN) {
> +             nskb = skb;
> +     } else {
> +             nskb = alloc_skb(NET_IP_ALIGN + skb->len +
> +                              padlen + KSZ_INGRESS_TAG_LEN, GFP_ATOMIC);

Hi Woojung

Thanks for reusing the existing skb when possible. This should help
with performance.

Reviewed-by: Andrew Lunn <and...@lunn.ch>

    Andrew