On Fri, 12 May 2017 01:04:46 +0200, Daniel Borkmann wrote: > For the dump, remove IFLA_XDP_FLAGS that was added with b5cdae3291f7 > and reuse IFLA_XDP_ATTACHED for indicating the mode. Dumping all > or just a subset of flags that were used for loading the XDP prog > is suboptimal in the long run since not all flags are useful for > dumping and if we start to reuse the same flag definitions for > load and dump, then we'll waste bit space. What we really just > want is to dump the mode for now. > > Current IFLA_XDP_ATTACHED semantics are: nothing was installed (0), > a program is running at the native driver layer (1). Thus, add a > mode that says that a program is running at generic XDP layer (2). > Applications will handle this fine in that older binaries will > just indicate that something is attached at XDP layer, effectively > this is similar to IFLA_XDP_FLAGS attr that we would have had > modulo the redundancy. > > Signed-off-by: Daniel Borkmann <dan...@iogearbox.net> > Acked-by: Alexei Starovoitov <a...@kernel.org>
Looks good to me, thanks!