On Friday 21 July 2006 21:49, Brice Goglin wrote:
> When writing the firmware to the NIC, the FIFO is 256-bytes long,
> so we use 256-bytes chunks and a read to wait until the previous
> write is done.
>
> Signed-off-by: Brice Goglin <[EMAIL PROTECTED]>
> ---
> drivers/net/myri10ge/myri10ge.c | 20 ++++++++------------
> 1 file changed, 8 insertions(+), 12 deletions(-)
>
> Index: linux-mm/drivers/net/myri10ge/myri10ge.c
> ===================================================================
> --- linux-mm.orig/drivers/net/myri10ge/myri10ge.c 2006-07-18
> 15:17:55.000000000 -0400
> +++ linux-mm/drivers/net/myri10ge/myri10ge.c 2006-07-18 15:19:44.000000000
> -0400
> @@ -448,6 +448,7 @@
> struct mcp_gen_header *hdr;
> size_t hdr_offset;
> int status;
> + unsigned i;
>
> if ((status = request_firmware(&fw, mgp->fw_name, dev)) < 0) {
> dev_err(dev, "Unable to load %s firmware image via hotplug\n",
> @@ -479,18 +480,13 @@
> goto abort_with_fw;
>
> crc = crc32(~0, fw->data, fw->size);
> - if (mgp->tx.boundary == 2048) {
> - /* Avoid PCI burst on chipset with unaligned completions. */
> - int i;
> - __iomem u32 *ptr = (__iomem u32 *) (mgp->sram +
> - MYRI10GE_FW_OFFSET);
> - for (i = 0; i < fw->size / 4; i++) {
> - __raw_writel(((u32 *) fw->data)[i], ptr + i);
> - wmb();
> - }
> - } else {
> - myri10ge_pio_copy(mgp->sram + MYRI10GE_FW_OFFSET, fw->data,
> - fw->size);
> + for (i = 0; i < fw->size; i += 256) {
> + myri10ge_pio_copy(mgp->sram + MYRI10GE_FW_OFFSET + i,
> + fw->data + i,
> + min(256U, (unsigned)(fw->size - i)));
> + mb();
> + readb(mgp->sram);
> + mb();
Why two mb() here?
I would say actually none is needed.
The readb fully synchronizes the previous writes on bus level
(and so on CPU level, too).
--
Greetings Michael.
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
