On Tue, 2017-05-09 at 15:50 +0200, Jason A. Donenfeld wrote: > The recent bug with macsec and historical one with virtio have > indicated that letting skb_to_sgvec trounce all over an sglist > without checking the length is probably a bad idea. And it's not > necessary either: an sglist already explicitly marks its last > item, and the initialization functions are diligent in doing so. > Thus there's a clear way of avoiding future overflows. > > So, this patchset, from a high level, makes skb_to_sgvec return > a potential error code, and then adjusts all callers to check > for the error code.
Perhaps you should add __must_check annotation to the function prototype(s)? johannes
