On Tue, May 02, 2017 at 02:31:50PM +0200, Jesper Dangaard Brouer wrote:
> Needed to adjust max locked memory RLIMIT_MEMLOCK for testing these bpf
> samples
> as these are using more and larger maps than can fit in distro default
> 64Kbytes limit.
>
> Signed-off-by: Jesper Dangaard Brouer <bro...@redhat.com>
...
> + struct rlimit r = {1024*1024, RLIM_INFINITY};
...
> + struct rlimit r = {1024*1024, RLIM_INFINITY};
why magic numbers?
All other samples do
struct rlimit r = {RLIM_INFINITY, RLIM_INFINITY};
> + if (setrlimit(RLIMIT_MEMLOCK, &r)) {
> + perror("setrlimit(RLIMIT_MEMLOCK)");
ip_tunnel.c test does:
perror("setrlimit(RLIMIT_MEMLOCK, RLIM_INFINITY)");
Few others do:
assert(!setrlimit(RLIMIT_MEMLOCK, &r));
and the rest just:
setrlimit(RLIMIT_MEMLOCK, &r);
We probalby need to move this to a helper.
> + struct rlimit r = {RLIM_INFINITY, RLIM_INFINITY};
here it's consistent :)
> + if (setrlimit(RLIMIT_MEMLOCK, &r)) {
> + perror("setrlimit(RLIMIT_MEMLOCK, RLIM_INFINITY)");
but with different perror ?
Let's do a common helper for all?
