On Tue, Apr 25, 2017 at 06:04:45PM +0200, Jiri Pirko wrote: > Tue, Apr 25, 2017 at 03:01:22PM CEST, j...@mojatatu.com wrote: > >On 17-04-25 08:13 AM, Jiri Pirko wrote: > >> Tue, Apr 25, 2017 at 01:54:06PM CEST, j...@mojatatu.com wrote: > > > > > >[..] > > > >> > -#define TCAA_MAX 1 > >> > +/* tcamsg flags stored in attribute TCA_ROOT_FLAGS > >> > + * > >> > + * TCA_FLAG_LARGE_DUMP_ON user->kernel to request for larger than > >> > TCA_ACT_MAX_PRIO > >> > + * actions in a dump. All dump responses will contain the number of > >> > actions > >> > + * being dumped stored in for user app's consumption in TCA_ROOT_COUNT > >> > + * > >> > + */ > >> > +#define TCA_FLAG_LARGE_DUMP_ON (1 << 0) > >> > >> BIT (I think I mentioned this before) > >> > > > >You did - but i took it out about two submissions back (per cover > >letter) because it is no part of UAPI today. I noticed devlink was > >using it but they defined their own variant. > >So if i added this, iproute2 doesnt compile. I could fix iproute2 > >to move it somewhere to a common header then restore this. > > So fix iproute2. It is always first kernel, then iproute2.
Perhaps I am missing the point or somehow misguided but I would expect that if the UAPI uses BIT() it also provides BIT(). ...
