On Tue, 2017-04-25 at 13:53 -0700, Jakub Kicinski wrote:
> On Tue, 25 Apr 2017 10:13:34 +0200, Johannes Berg wrote:
> > On Tue, 2017-04-25 at 01:06 -0700, Jakub Kicinski wrote:
> >
> > > +#define NL_SET_ERR_MSG(extack, msg) do { \
> > > + struct netlink_ext_ack *_extack = (extack); \
> > > + static const char _msg[] = (msg); \
> > > + \
> > > + if (_extack) \
> > > + _extack->_msg = _msg; \
> > > + else \
> > > + pr_info("%s\n", _msg); \
> > > } while (0)
> I'm leaning towards dropping the else clause and never printing, that
> will add an incentive for people to convert more paths to provide the
> ext ack. Any thoughts on that?
Personally, I'm happy with that.
johannes
