> From: Sven Eckelmann [mailto:s...@narfation.org] > Sent: Tuesday, April 25, 2017 9:53 PM > On Dienstag, 25. April 2017 20:03:20 CEST gfree.w...@foxmail.com wrote: > > From: Gao Feng <f...@ikuai8.com> > > > > Because the func batadv_softif_init_late allocate some resources and > > it would be invoked in register_netdevice. So we need to invoke the > > func batadv_softif_free instead of free_netdev to cleanup when fail to > > register_netdevice. > > I could be wrong, but shouldn't the destructor be replaced with free_netdevice > and the batadv_softif_free (without the free_netdev) used as ndo_uninit? The > line you've changed should then be kept as free_netdevice. > > At least this seems to be important when using rtnl_newlink() instead of the > legacy sysfs netdev stuff from batman-adv. rtnl_newlink() would also only call > free_netdevice and thus also not run batadv_softif_free. This seems to be only > fixable by calling ndo_uninit. > > Kind regards, > Sven
Sorry, I don't get you. The net_dev is created in this func batadv_softif_create. Why couldn't invoke batadv_softif_free to cleanup when fail to register_netdevice? Best Regards Feng
