On Tue, 25 Apr 2017 08:53:35 -0600, David Ahern wrote: > On 4/25/17 2:06 AM, Jakub Kicinski wrote: > > > Also - is anyone working on adding proper extack support to iproute2? > > The code I have right now is a bit of a hack... > > This is what I have done: > https://github.com/dsahern/iproute2/commits/ext-ack > > Basically, added the parsing code and then a new rtnl_talk_extack > function that takes a callback to invoke with the extack data. The last > patch (of 3) purposely breaks ip set link mtu -- sending the mtu as a > u16 rather than a u32 just to work on the plumbing for parsing the > returned message: > > $ ip li set dummy1 mtu 1490 > Error with rtnetlink attribute IFLA_MTU > > If an errmsg is returned it is printed as well.
Great, that's much better than what I have. It will make the XDP patch for iproute2 pretty trivial :)