On 17-04-24 09:48 PM, Jamal Hadi Salim wrote:
On 17-04-24 09:20 PM, Jakub Kicinski wrote:
On Mon, 24 Apr 2017 20:58:18 -0400, Jamal Hadi Salim wrote:
On 17-04-24 02:32 PM, David Miller wrote:
You have 3 TLVs, one of which is u8 that only allows use of 3 bits.
The other is a u32 which allows only 20 bits to be set.
I don't think we will ever reuse bits in a field which is called
MPLS_LABEL for anything else than an MPLS label.
That is true. So maybe bad example. It also helps the mpls disector
wont for example allow copying of more than 20 bits for a label.
Hrm. maybe I am wrong.
Lets say user sets all of the 8 bits in BOS,
what does setting
key_val->mpls_bos = nla_get_u8 do?
Same with the 20 bits for the label in the u32
or 3 bit bits in the u8 tc.
cheers,
jamal
