Quoting Herbert Xu: | > case SO_NO_CHECK: | > - sk->sk_no_check = valbool; | > + /* UDP-Lite (RFC 3828) mandates checksumming, | > + * hence user must not enable this option. */ | > + if (sk->sk_protocol == IPPROTO_UDPLITE) | > + ret = -EOPNOTSUPP; | > + else | > + sk->sk_no_check = valbool; | | Please don't add protocol-specific stuff to generic functions. In this | case why don't you just ignore sk_no_check for UDPLITE as we do for TCP?
Thank you for spotting this -- the UDP-Lite code indeed ignores sk_no_check and will (if no socket options are set) emulate UDP with sk_no_check = 0. Setting it to 1 will make no difference; so the above is more not strictly necessary. Will remove in next patch. Any other comments or ideas, please do not hesitate to write. -- Gerrit - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
