On 17-04-20 08:18 AM, Eric Dumazet wrote:
On Thu, 2017-04-20 at 06:42 -0400, Jamal Hadi Salim wrote:
They are not the same issue Jiri. We have used bitmasks fine on netlink
message for a millenia. Nobody sets garbage on a bitmask they are not
supposed to touch. The struct padding thing is a shame the way it
turned out - now netlink can no longer have a claim to be a (good)
wire protocol.
Except that users wrote programs, and these programs work today.
By changing the kernel and recognizing new flags in existing padding,
you might break the programs.
This is not acceptable. Period.
Had we checked the padding being 0 in old kernels, this change would
have been possible today.
But because old kernels did not care of the padding contents, then there
is no way new kernel can suddenly trust them at all.
Please Jamal, you have to forget this nonsense.
That is fine. We can rule out netlink ever being able to work
across machines. That was the dream in the past. Lets close that
discussion.
The issue Jiri is bringing up is unrelated. He is talking about
a bitmap and conflating it with a data structure. They are not
the same issue.
cheers,
jamal
