> From: "Sudarsana Reddy Kalluru" <sudarsana.kall...@cavium.com> > To: da...@davemloft.net > Cc: netdev@vger.kernel.org, "Yuval Mintz" <yuval.mi...@cavium.com> > Sent: Wednesday, 19 April, 2017 6:19:54 AM > Subject: [PATCH net 3/4] qed: Fix possible system hang in the dcbnl-getdcbx() > path. > > qed_dcbnl_get_dcbx() API uses kmalloc in GFT_KERNEL mode. The API gets > invoked in the interrupt context by qed_dcbnl_getdcbx callback. Need > to invoke this kmalloc in atomic mode. > > Signed-off-by: Sudarsana Reddy Kalluru <sudarsana.kall...@cavium.com> > Signed-off-by: Yuval Mintz <yuval.mi...@cavium.com> > --- > drivers/net/ethernet/qlogic/qed/qed_dcbx.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/net/ethernet/qlogic/qed/qed_dcbx.c > b/drivers/net/ethernet/qlogic/qed/qed_dcbx.c > index ff058a3..8f0783a 100644 > --- a/drivers/net/ethernet/qlogic/qed/qed_dcbx.c > +++ b/drivers/net/ethernet/qlogic/qed/qed_dcbx.c > @@ -1264,7 +1264,7 @@ static struct qed_dcbx_get *qed_dcbnl_get_dcbx(struct > qed_hwfn *hwfn, > { > struct qed_dcbx_get *dcbx_info; > > - dcbx_info = kzalloc(sizeof(*dcbx_info), GFP_KERNEL); > + dcbx_info = kmalloc(sizeof(*dcbx_info), GFP_ATOMIC);
You are changing a kzalloc to kmalloc, was that intentional? > if (!dcbx_info) > return NULL; > > -- > 1.8.3.1 > >