> -----Original Message----- > From: David Miller [mailto:da...@davemloft.net] > > > From: Ilan Tayari <il...@mellanox.com> > > > > Commit 07b26c9454a2 ("gso: Support partial splitting at the frag_list > > pointer") assumes that all SKBs in a frag_list (except maybe the last > > one) contain the same amount of GSO payload. > > > > This assumption is not always correct, resulting in the following > > warning message in the log: > > skb_segment: too many frags > > > > For example, mlx5 driver in Striding RQ mode creates some RX SKBs with > > one frag, and some with 2 frags. > > After GRO, the frag_list SKBs end up having different amounts of > payload. > > If this frag_list SKB is then forwarded, the aforementioned assumption > > is violated. > > > > Validate the assumption, and fall back to software GSO if it not true. > > > > Fixes: 07b26c9454a2 ("gso: Support partial splitting at the frag_list > > pointer") > > Signed-off-by: Ilan Tayari <il...@mellanox.com> > > Signed-off-by: Ilya Lesokhin <il...@mellanox.com> > > --- > > Your commit message mentions a fixes tag which make this change seem > relevant for 'net', but your patch depends upon things in 'net-next' > and therefore only applies there. > > I've added this change to net-next, but I want an explanation of why this > change is not targettting 'net' if it seems to fix a problem there. > > Thanks.
Sorry, my mistake. This fix does belong to 'net', but this patch needs a modification to be applied there. I will send a patch for 'net' as well. Thanks
