Re: [PATCH v2 net 1/2] net sched actions: fix access to uninitialized data

[Jamal Hadi Salim]

On 17-04-18 06:13 AM, Wolfgang Bumiller wrote:

Signed-off-by: Wolfgang Bumiller <w.bumil...@proxmox.com>
Acked-by: Cong Wang <xiyou.wangc...@gmail.com>
Acked-by: Jamal Hadi Salim <j...@mojatatu.com>
---
(same as v1)

 net/sched/act_api.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/net/sched/act_api.c b/net/sched/act_api.c
index b70aa57319ea..8cc883c063f0 100644
--- a/net/sched/act_api.c
+++ b/net/sched/act_api.c
@@ -604,7 +604,7 @@ struct tc_action *tcf_action_init_1(struct net *net, struct 
nlattr *nla,
        if (err < 0)
                goto err_mod;

-       if (tb[TCA_ACT_COOKIE]) {
+       if (name == NULL && tb[TCA_ACT_COOKIE]) {
                int cklen = nla_len(tb[TCA_ACT_COOKIE]);

                if (cklen > TC_COOKIE_MAX_SIZE) {

This one looks good.

cheers,
jamal