> -----Original Message----- > From: Miroslav Lichvar [mailto:[email protected]] > Sent: Wednesday, April 12, 2017 7:18 AM > To: [email protected] > Cc: Richard Cochran <[email protected]>; Willem de Bruijn > <[email protected]>; Soheil Hassas Yeganeh <[email protected]>; Keller, > Jacob E <[email protected]>; Denny Page <[email protected]>; Jiri > Benc <[email protected]> > Subject: [RFC PATCH 0/7] Extend socket timestamping API > > This patchset adds new options to the timestamping API that will be > useful for NTP implementations and possibly other applications. > > The first patch specifies a timestamp filter for NTP packets, which is > handled in the second patch in drivers that can timestamp all packets. > There is no attempt to add the support to the phyter driver. > > The third patch adds a new option to get information about > HW-timestamped packets. The fourth patch adds support for this option to > the drivers (currently only igb and e1000e). > > The fifth patch fixes the code to not make a false software TX timestamp > when HW timestamping is enabled. The sixth patch depends on this fix. > > The sixth patch adds a new option to allow outgoing packets to be looped > multiple times to the error queue in order to allow simultaneous SW and > HW timestamping. The seventh patch updates drivers that assumed SW > timestamping cannot be used together with HW timestamping. >
I think this looks pretty good, straight forward and useful. I agree with Richard about the one commit message, but the rest looks good modulo missing updates for all the other drivers. I didn't see any code to update the ethtool get_ts_info data for _NTP_ALL either. Thanks, Jake
