From: "Michael S. Tsirkin" <m...@redhat.com>
Date: Wed, 12 Apr 2017 19:43:20 +0300

> On Wed, Apr 12, 2017 at 05:08:24PM +0100, Stefan Hajnoczi wrote:
>> +struct af_vsockmon_hdr {
>> +    __le64 src_cid;
>> +    __le64 dst_cid;
>> +    __le32 src_port;
>> +    __le32 dst_port;
>> +    __le16 op;                      /* enum af_vsockmon_op */
>> +    __le16 transport;               /* enum af_vsockmon_transport */
>> +    __le16 len;                     /* Transport header length */
>> +} __attribute__((packed));
> 
> I'd add a 2 byte padding here and then you do not need to pack it.

Indeed, use of the packed attribute is strongly discouraged.

Reply via email to