On 04/10/2017 05:16 PM, David Laight wrote: > From: Ursula Braun >> Sent: 07 April 2017 08:16 >> Avoid endianness warnings reported by sparse by (1) using endianness >> conversions for assigning and using network packet fields, and (2) >> removing unnecessary endianness conversions from qeth_l3_rebuild_skb. No >> functional changes. > ... >> - if (*p == ETH_P_8021Q) >> + if (be16_to_cpu(*p) == ETH_P_8021Q) > ... > > This is clearly different on little-endian systems. > Also (probably) better written as: > > if (*p == cpu_to_be16(ETH_P_8021Q)) > > so that the constant can by byteswapped. > > David >
Thanks, we will keep that in mind for future patches. > >
