On Thu, Apr 06, 2017 at 06:47:35AM -0700, Florian Fainelli wrote:
> When CONFIG_OF=n, we will see the following warning:
>
> drivers/net/dsa/mv88e6xxx/chip.c:2834:34: warning:
> 'mv88e6xxx_mdio_external_match' defined but not used
> [-Wunused-const-variable=]
> static const struct of_device_id mv88e6xxx_mdio_external_match[] = {
> ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>
> Signed-off-by: Florian Fainelli <[email protected]>
> ---
> drivers/net/dsa/mv88e6xxx/chip.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/net/dsa/mv88e6xxx/chip.c
> b/drivers/net/dsa/mv88e6xxx/chip.c
> index 44ba8cff5631..64cbc4c04907 100644
> --- a/drivers/net/dsa/mv88e6xxx/chip.c
> +++ b/drivers/net/dsa/mv88e6xxx/chip.c
> @@ -2831,11 +2831,13 @@ static int mv88e6xxx_mdio_register(struct
> mv88e6xxx_chip *chip,
> return 0;
> }
>
> +#ifdef CONFIG_OF
> static const struct of_device_id mv88e6xxx_mdio_external_match[] = {
> { .compatible = "marvell,mv88e6xxx-mdio-external",
> .data = (void *)true },
> { },
> };
> +#endif
Hi Florian
Maybe a better fix is to make the stub of of_match_node() an inline
function, so its parameters are used. That will fix this warning
everywhere in the kernel, not just in this driver.
Andrew
