On Wed, Apr 5, 2017 at 11:49 AM, Eric Dumazet <[email protected]> wrote: > From: Eric Dumazet <[email protected]> > > mlx4 is the only driver in the tree making a point to recompute > shinfo->gso_segs. > > Lets remove superfluous code. > > Signed-off-by: Eric Dumazet <[email protected]> > Cc: Tariq Toukan <[email protected]> > Cc: Saeed Mahameed <[email protected]> > --- > drivers/net/ethernet/mellanox/mlx4/en_tx.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/drivers/net/ethernet/mellanox/mlx4/en_tx.c > b/drivers/net/ethernet/mellanox/mlx4/en_tx.c > index > e0c5ffb3e3a6607456e1f191b0b8c8becfc71219..3ba89bc43d74d8c023776079bcd0bbadd70fb5c6 > 100644 > --- a/drivers/net/ethernet/mellanox/mlx4/en_tx.c > +++ b/drivers/net/ethernet/mellanox/mlx4/en_tx.c > @@ -978,8 +978,7 @@ netdev_tx_t mlx4_en_xmit(struct sk_buff *skb, struct > net_device *dev) > > ring->tso_packets++; > > - i = ((skb->len - lso_header_size) / shinfo->gso_size) + > - !!((skb->len - lso_header_size) % shinfo->gso_size); > + i = shinfo->gso_segs; > tx_info->nr_bytes = skb->len + (i - 1) * lso_header_size; > ring->packets += i; > } else { > >
Reviewed-by: Saeed Mahameed <[email protected]>
