On Tue, Apr 04, 2017 at 06:54:25PM +0100, Joao Pinto wrote:
[...]
> diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c
> b/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c
[...]
> @@ -3402,6 +3474,9 @@ static irqreturn_t stmmac_interrupt(int irq, void
> *dev_id)
>
> if (priv->synopsys_id >= DWMAC_CORE_4_00) {
> for (queue = 0; queue < queues_count; queue++) {
> + struct stmmac_rx_queue *rx_q =
> + &priv->rx_queue[queue];Found one more: the indentation here looks wrong. I think it's more idiomatic to indent by at least a tab in such cases. > + > status |= > priv->hw->mac->host_mtl_irq_status(priv->hw, > queue); This is becoming quite unwieldy because of the indentation levels. Maybe this could be split out into a separate function. Could be a separate patch, though. Thierry
signature.asc
Description: PGP signature
