Re: [PATCH net-next v2 2/9] net: dsa: mv88e6xxx: use 4-bit port for PVT data

[Andrew Lunn]

> +/* Offset 0x1D: Misc Register */
> +
> +static int mv88e6xxx_g2_misc_5_bit_port(struct mv88e6xxx_chip *chip,
> +                                     bool port_5_bit)
> +{
> +     u16 val;
> +     int err;
> +
> +     err = mv88e6xxx_g2_read(chip, GLOBAL2_MISC, &val);
> +     if (err)
> +             return err;
> +
> +     if (port_5_bit)
> +             val |= GLOBAL2_MISC_5_BIT_PORT;
> +     else
> +             val &= ~GLOBAL2_MISC_5_BIT_PORT;
> +
> +     return mv88e6xxx_g2_write(chip, GLOBAL2_MISC, val);
> +}
> +
> +int mv88e6xxx_g2_misc_4_bit_port(struct mv88e6xxx_chip *chip)
> +{
> +     return mv88e6xxx_g2_misc_5_bit_port(chip, false);
> +}

Hi Vivien

Yes, i know, i'm nit-picking. The function naming is confusing here.
What would you call this function:

int mv88e6xxx_g2_misc_XXXXX(struct mv88e6xxx_chip *chip)
{
        return mv88e6xxx_g2_misc_5_bit_port(chip, true);
}

Thanks
        Andrew