From: Or Gerlitz <[EMAIL PROTECTED]> Date: Mon, 10 Jul 2006 16:43:36 +0300 (IDT)
> Looking on the linux bonding driver, it seems to unconditionally (*) > assume that the enslaved device supports the set_mac_address call. > > >From reading the doc (Documentation/networking/bonding.txt) i understand that > it is **not** a must prerequisite for the active-backup mode, this is since > there is at most one active slave at each point of time and as the doc states: > > when a failover occurs in active-backup mode, bonding will issue > one or more gratuitous ARPs on the newly active slave. > > I'd like to get feedback from people here if you think it makes sense > to change the bonding driver to actually allow for active-backup/bonding > with network device drivers which does not support set_mac_address. Blindly dereferencing the ->set_mac_address method is wrong, it does seem. Regardless of whether we add support for active-backup/bonding for devices without this method, in the mean time the bonding driver should check for whether that method is NULL and disallow the bond configuration if it is. - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
