Re: [PATCH net-next 4/9] net: dsa: mv88e6xxx: allocate the number of ports

[Vivien Didelot]

Hi Andrew,

Andrew Lunn <and...@lunn.ch> writes:

> On Wed, Mar 29, 2017 at 04:30:15PM -0400, Vivien Didelot wrote:
>> The current code allocates DSA_MAX_PORTS ports for a Marvell dsa_switch
>> structure. Provide the exact number of ports so the corresponding
>> ds->num_ports is accurate.
>
> Is net/dsa/dsa.c: dsa_switch_setup() still used?  If it is, won't that
> invalidate your assumption about ds->num_ports.

I think dsa_switch_setup is part of the legacy code and is likely to be
removed soon.

But this is not an issue per-se. What happens if the switch is allocated
with DSA_MAX_PORTS ports instead of the correct number, is that the PVT
will be programmed to allow the non-existent port IDs to egress frames
on the CPU port and DSA links only.

Thanks,

        Vivien