From: Guillaume Nault <g.na...@alphalink.fr>
Date: Tue, 28 Mar 2017 15:32:35 +0200

> The code following l2tp_tunnel_find() expects that a new reference is
> held on sk. Either sk_receive_skb() or the discard_put error path will
> drop a reference from the tunnel's socket.
> 
> This issue exists in both l2tp_ip and l2tp_ip6.
> 
> Signed-off-by: Guillaume Nault <g.na...@alphalink.fr>

You introduced this bug in commit:

====================
commit a3c18422a4b4e108bcf6a2328f48867e1003fd95
Author: Guillaume Nault <g.na...@alphalink.fr>
Date:   Tue Nov 29 13:09:45 2016 +0100

    l2tp: hold socket before dropping lock in l2tp_ip{, 6}_recv()
====================

Therefore you should make this clear with a proper "Fixes: " tag
such as:

Fixes: a3c18422a4b4 ("l2tp: hold socket before dropping lock in l2tp_ip{, 
6}_recv()")

on a line right before your signoff.

Reply via email to