> -----Original Message----- > From: David Miller [mailto:da...@davemloft.net] > Sent: Saturday, March 25, 2017 8:01 PM > To: Kirsher, Jeffrey T <jeffrey.t.kirs...@intel.com> > Cc: Wyborny, Carolyn <carolyn.wybo...@intel.com>; > netdev@vger.kernel.org; nhor...@redhat.com; sassm...@redhat.com; > jogre...@redhat.com > Subject: Re: [net-next 05/11] i40e: fix for queue timing delays > > From: Jeff Kirsher <jeffrey.t.kirs...@intel.com> > Date: Sat, 25 Mar 2017 01:12:59 -0700 > > > From: Carolyn Wyborny <carolyn.wybo...@intel.com> > > > > This patch adds a delay to Rx queue disables to accommodate HW needs. > > [..] > > + /* HW needs up to 50ms to finish RX queue disable*/ > > + mdelay(50); > > You just polled a register which indicates that the request is finished. > Needing futher time for the operation to complete doesn't make any > sense. > > If this is really needed, you need to explain in the commit message, in > detail, what is really the problem here. > > THanks.
It's a hw limitation, will submit an updated patch with more detail. Thanks, Carolyn Carolyn Wyborny Linux Development Networking Division Intel Corporation
