Fri, Mar 24, 2017 at 06:46:55PM CET, xiyou.wangc...@gmail.com wrote:
>On Fri, Mar 24, 2017 at 6:39 AM, Jiri Pirko <j...@resnulli.us> wrote:
>> From: Jiri Pirko <j...@mellanox.com>
>>
>> In atm_tc_destroy, the flow qdisc filter chains are destroyed. However
>> the main chain is not. So fix this memory and reference leak.
>
>Are you sure? 'link' is on the 'flows' already according
Ah. You are correct. Scratch this. Thanks.
Btw, I think that in atm_tc_change:
list_add(&flow->list, &p->link.list);
should be:
list_add(&flow->list, &p->flows);
>to this comment:
>
>struct atm_qdisc_data {
> struct atm_flow_data link; /* unclassified skbs go here */
> struct list_head flows; /* NB: "link" is also on this
> list */
> struct tasklet_struct task; /* dequeue tasklet */
>};
