On Mon, Mar 20, 2017 at 6:09 PM, Sergei Shtylyov
<[email protected]> wrote:
> On 3/20/2017 12:55 PM, [email protected] wrote:
>
>> From: Gao Feng <[email protected]>
>>
>> In the commit <93557f53e1fb> ("netfilter: nf_conntrack: nf_conntrack snmp
>
>
> Angle brackets not needed. :-)
> The commit citing style is the same as for the Fixes: tag.
The checkpatch.pl reports the following error, if remove the angle brackets.
ERROR: Please use git commit description style 'commit <12+ chars of
sha1> ("<title line>")' - ie: 'commit fatal: ambig ("evision or path
not in the working tree.")'
#7:
In the commit 93557f53e1fb ("netfilter: nf_conntrack: nf_conntrack snmp
total: 1 errors, 0 warnings, 0 checks, 27 lines checked
Regards
Feng
>
>> helper"), the snmp_helper is replaced by nf_nat_snmp_hook. So the
>> snmp_helper is never registered. But it still tries to unregister the
>> snmp_helper, it could cause the panic.
>>
>> Now remove the useless snmp_helper and the unregister call in the
>> error handler.
>>
>> Fixes: 93557f53e1fb ("netfilter: nf_conntrack: nf_conntrack snmp helper")
>>
>> Signed-off-by: Gao Feng <[email protected]>
>
> [...]
>
> MBR, Sergei
>
