On Thu, Mar 16, 2017 at 10:28 AM, Pravin Shelar <pshe...@ovn.org> wrote: > On Tue, Mar 14, 2017 at 4:08 PM, Andy Zhou <az...@ovn.org> wrote: >> add_deferred_actions() API currently requires actions to be passed in >> as a fully encoded netlink message. So far both 'sample' and 'recirc' >> actions happens to carry actions as fully encoded netlink messages. >> However, this requirement is more restrictive than necessary, future >> patch will need to pass in action lists that are not fully encoded >> by themselves. > > It is not obvious why this change is required? > can you explain it.
The original 'attr' requires a nested netlink message for the callee to get the size of the actions list. In the sample case, since we rewrite sample into an internal format that does not have actions encoded as a nested netlink, we will need to pass both pointer to the first action, and the size of the actions list.