On Thu, 2006-06-07 at 14:45 +0200, Thomas Graf wrote: > * jamal <[EMAIL PROTECTED]> 2006-07-06 08:27 > > > > The proper patch is attached as a replacement for > > "[PATCH 3/3] [PKT_SCHED]: Fix error handling while dumping action" > > from Thomas. > > If you have already submitted it, then i will send a patch against it. > > I don't understand why you're picky about this but if you really > want to then do it properly and remove the now unused err variable, > don't leave obscure code behind again.
For heavens sake, do we have to argue even about this? look at the code calmly and rationally and tell me if your fix was even close to right. It was a bug. All bugs are obscure. cheers, jamal - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
