On Mon, Mar 13, 2017 at 04:28:04PM -0700, Eric Dumazet wrote:
> On Mon, Mar 13, 2017 at 4:21 PM, Alexei Starovoitov
> <[email protected]> wrote:
> >
> > is it once in the beginning only? If so then why that
> > 'if (!ring->page_cache.index)' check is done for every packet?
>
>
>
> You did not really read the patch, otherwise you would not ask these
> questions.
please explain. I see
+ if (!ring->page_cache.index) {
+ npage = mlx4_alloc_page(priv, ring,
which is done for every packet that goes via XDP_TX.
> Test it, and if you find a regression, shout loudly.
that's not how it works. It's a job of submitter to prove
that additional code doesn't cause regressions especially
when there are legitimate concerns.
