On Tue, Jul 04, 2006 at 12:45:27PM +1000, herbert wrote: > > That's what I meant. I meant ethtool helper functions that > clear and set both TSO/TSO6 flags at the same time.
I think I was a bit ambiguous here. To expand on my argument, what I'm saying is that we can't just change the existing ethtool helper functions to set TSO6 since that'd break NICs which do not support TSO6. Instead of adding an ad-hoc ethtool function in the neterion driver, we should either add a new ethtool function which sets both TSO/TSO6, or do the following. > Alternatively, we can add a new features bit which gives the inherent > features of a device. That can then be used to derive the actual > features in use. That way we won't need to invent a new ethtool > helper function for this. Cheers, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmV>HI~} <[EMAIL PROTECTED]> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
