Le 03/05/17 à 12:26, Florian Fainelli a écrit :
> The Generic PHY driver is a catch-all PHY driver and it should preserve
> whatever prior initialization has been done by boot loader or firmware
> agents. For specific PHY device configuration it is expected that a
> specialized PHY driver would take over that role.
>
> Resetting the generic PHY was a bad idea that has lead to several
> complaints and downstream workarounds e.g: in OpenWrt/LEDE so restore
> the behavior prior to 87aa9f9c61ad ("net: phy: consolidate PHY
> reset in phy_init_hw()").
>
> Reported-by: Felix Fietkau <n...@nbd.name>
> Fixes: 87aa9f9c61ad ("net: phy: consolidate PHY reset in phy_init_hw()")
> Signed-off-by: Florian Fainelli <f.faine...@gmail.com>
And I forgot to include include/linux/phy.h in the patch so it won't
build, v2 coming.
> ---
> drivers/net/phy/phy_device.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/phy/phy_device.c b/drivers/net/phy/phy_device.c
> index daec6555f3b1..5198ccfa347f 100644
> --- a/drivers/net/phy/phy_device.c
> +++ b/drivers/net/phy/phy_device.c
> @@ -1864,7 +1864,7 @@ static struct phy_driver genphy_driver[] = {
> .phy_id = 0xffffffff,
> .phy_id_mask = 0xffffffff,
> .name = "Generic PHY",
> - .soft_reset = genphy_soft_reset,
> + .soft_reset = genphy_no_soft_reset,
> .config_init = genphy_config_init,
> .features = PHY_GBIT_FEATURES | SUPPORTED_MII |
> SUPPORTED_AUI | SUPPORTED_FIBRE |
>
--
Florian
