Hi Julian, Thanks a lot for the comments. I will send a v2 patch.
Regards Hangbin 2017-02-19 22:04 GMT+08:00 Julian Anastasov <[email protected]>: > > Hello, > > On Fri, 17 Feb 2017, Hangbin Liu wrote: > >> Fix and add some new ipvs sysctl options. Also use tab instead of whitespaces >> to indent the descriptions. > > You change only docs, so the patchset should be for > the net-next tree. > >> Hangbin Liu (4): >> ipvs: fix sync_threshold description and add sync_refresh_period, >> sync_retries >> ipvs: Document sysctl sync_qlen_max and sync_sock_size > > - we can add "are " here but then also check if lines become too long: > > "Hard limit for queued sync messages that [are ]not sent yet." > > You can also move the "commit" word to next line > to make checkpatch happy: > > scripts/checkpatch.pl --strict /tmp/file2.patch > >> ipvs: Document sysctl sync_ports >> ipvs: Document sysctl pmtu_disc > > - we can make it like this: > > "By default, reject with FRAG_NEEDED all DF packets that exceed > the PMTU, irrespective of the forwarding method. For TUN method > the flag can be disabled to fragment such packets." > >> Documentation/networking/ipvs-sysctl.txt | 68 >> ++++++++++++++++++++++++++++---- >> 1 file changed, 60 insertions(+), 8 deletions(-) > > Regards > > -- > Julian Anastasov <[email protected]>
