----- On Feb 6, 2017, at 2:58 PM, laforge lafo...@gnumonks.org wrote:
> Hi Andreas, > > On Mon, Jan 30, 2017 at 05:37:11PM +0100, Andreas Schultz wrote: >> Consolidate duplicate code into helper. > > Makes complete sense. > > However: > >> +static void pdp_context_delete(struct pdp_ctx *pctx); >> + > > why introduce the forward-declaration and then define the function > further down in the file? I think in general, it is preferred to put > helper functions on top, before their first use, so forward declarations > can be avoided? Particularly if the helper function doesn't call any > other functions that are not yet declared at this point. I wanted to keep functions that work on the data structure close together. I this case the function the initialized the pdp context and the delete function for it. Andreas > > Please note the above might just be my personal taste, not sure if > that's a general habit in the kernel networking code these days. > > So with or without the re-ordering: > > Acked-by: Harald Welte <lafo...@gnumonks.org> > > -- > - Harald Welte <lafo...@gnumonks.org> http://laforge.gnumonks.org/ > ============================================================================ > "Privacy in residential applications is a desirable marketing option." > (ETSI EN 300 175-7 Ch. A6)
