From: jamal <[EMAIL PROTECTED]> Date: Thu, 29 Jun 2006 20:26:20 -0400
> On Thu, 2006-29-06 at 17:12 -0700, David Miller wrote: > > The objects around it are pointers, which are 64-bit, and thus > > the 32-bit object gets padded out to 64-bits in the layout of > > the struct so that the next pointer member can be properly > > aligned. > > > > It does not change the size of sk_buff at all. > > > > I see; i take it if things were moved around that may change? Yes. > > > Yes, it is a bug, but: > > > dev_hold/put dont work anymore? why do you need an ifindex instead? > > > > You sure you want to do that atomic operation on every single > > input packet, regardless of whether egress operations are > > using it or not? > > > > Can you avoid doing the refcount? > Note Thomas is doing dev_get_by_index (which will do the atomic ref > count). He is doing that where skb->input_device is needed, which is what we want. > I didnt quiet follow, the ref count seems only needed in the > redirection, no? I'm saying that, we don't need the refcount, just setting the skb->input_index thing, unless someone actually cares about the input device. As long as the packet hits not paths that care about the SKB input device, no atomic refcounts are taken. It's just an integer sitting there in the SKB. - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
