These checks are off by one.  These are just sanity checks and we don't
ever pass invalid values for "encap_type" so it's harmless.

Fixes: 9b4108012517 ("sfc: insert catch-all filters for encapsulated traffic")
Signed-off-by: Dan Carpenter <dan.carpen...@oracle.com>

diff --git a/drivers/net/ethernet/sfc/ef10.c b/drivers/net/ethernet/sfc/ef10.c
index 8bec9383d754..dec0c8083ff3 100644
--- a/drivers/net/ethernet/sfc/ef10.c
+++ b/drivers/net/ethernet/sfc/ef10.c
@@ -5080,7 +5080,7 @@ static int efx_ef10_filter_insert_def(struct efx_nic *efx,
 
                /* quick bounds check (BCAST result impossible) */
                BUILD_BUG_ON(EFX_EF10_BCAST != 0);
-               if (encap_type > ARRAY_SIZE(map) || map[encap_type] == 0) {
+               if (encap_type >= ARRAY_SIZE(map) || map[encap_type] == 0) {
                        WARN_ON(1);
                        return -EINVAL;
                }
@@ -5134,7 +5134,7 @@ static int efx_ef10_filter_insert_def(struct efx_nic *efx,
 
                /* quick bounds check (BCAST result impossible) */
                BUILD_BUG_ON(EFX_EF10_BCAST != 0);
-               if (encap_type > ARRAY_SIZE(map) || map[encap_type] == 0) {
+               if (encap_type >= ARRAY_SIZE(map) || map[encap_type] == 0) {
                        WARN_ON(1);
                        return -EINVAL;
                }

Reply via email to