Em Tue, Jan 31, 2017 at 01:08:27PM -0300, Arnaldo Carvalho de Melo escreveu: > Em Mon, Jan 30, 2017 at 09:58:05PM -0300, Arnaldo Carvalho de Melo escreveu: > > Em Mon, Jan 30, 2017 at 01:16:18PM -0800, Joe Stringer escreveu: > > > On 30 January 2017 at 12:28, Arnaldo Carvalho de Melo <a...@kernel.org> > > > wrote: > > > > --- > > > > Thus, a return value of size or more means that the output was > > > > truncated. > > > > --- > > > > > Good spotting, I looked over the committed versions and tested them, > > > they seem good to me. Thanks! > > > > Thanks for checking, will push Ingo's way after a battery of extra > > tests, tomorrow, > > Which failed for centos:5, centos:6, centos:7, debian:7, debian:8, > debian:experimental and others, I stopped the test at this point, > working on fixing it. > > All seems related to: > > libbpf.c:1267: error: 'BPF_FS_MAGIC' undeclared (first use in this function) > libbpf.c:1267: error: (Each undeclared identifier is reported only once > libbpf.c:1267: error: for each function it appears in.)
We need to carry a tools/include/uapi/linux/magic.c copy, check if it drifts, remove the ifdefs for _FS_MAGIC defines from tools/ and use that instead, etc, till then I'll just add the ifdef to libbpf.c. [acme@jouet linux]$ grep BPF_FS_MAGIC /usr/include/*/*.h /usr/include/linux/magic.h:#define BPF_FS_MAGIC 0xcafe4a11 [acme@jouet linux]$ rpm -qf /usr/include/linux/magic.h kernel-headers-4.9.6-200.fc25.x86_64 [acme@jouet linux]$ cat /etc/fedora-release Fedora release 25 (Twenty Five) [acme@jouet linux]$ But those other distros don't have it. - Arnaldo
