On Mon, Jan 30, 2017 at 9:13 PM, Jakub Kicinski <kubak...@wp.pl> wrote:
> On Mon, 30 Jan 2017 20:47:47 -0800, Alexei Starovoitov wrote:
>> On Mon, Jan 30, 2017 at 08:49:25PM -0500, Michael Chan wrote:
>> > The first 8 patches refactor the code (rx/tx code paths and ring logic)
>> > and add the basic infrastructure to support XDP. The 9th patch adds
>> > basic ndo_xdp to support XDP_DROP and XDP_PASS only. The 10th patch
>> > completes the series with XDP_TX.
>>
>> Looks great.
>> Could you please share performance numbers ?
>>
>> Also please add something like:
>> if (prog && prog->xdp_adjust_head) {
>> netdev_warn(dev, "Does not support bpf_xdp_adjust_head()\n");
>> return -EOPNOTSUPP;
>> }
>> unless you plan to add adjut_head support until net-next closes.
>> Note, it's must have for load balancer functionality.
>
> I was about to ask whether it's OK at this point to add XDP support
> without xdp_adjust_head()? My understanding was that this is basic
> functionality and therefore required?
I need to first figure out what xdp_adjust_head means. If it is ok,
I'd like to defer it.
>
> FWIW the check you requested is there in patch 9.
Yes, it is in there. I just copied the same code from other drivers.
