On Mon, Jan 30, 2017 at 10:49:36AM +0100, Michal Hocko wrote:
> From: Michal Hocko <[email protected]>
>
> There are many code paths opencoding kvmalloc. Let's use the helper
> instead. The main difference to kvmalloc is that those users are usually
> not considering all the aspects of the memory allocator. E.g. allocation
> requests <= 32kB (with 4kB pages) are basically never failing and invoke
> OOM killer to satisfy the allocation. This sounds too disruptive for
> something that has a reasonable fallback - the vmalloc. On the other
> hand those requests might fallback to vmalloc even when the memory
> allocator would succeed after several more reclaim/compaction attempts
> previously. There is no guarantee something like that happens though.
>
> This patch converts many of those places to kv[mz]alloc* helpers because
> they are more conservative.
>
> Changes since v1
> - add kvmalloc_array - this might silently fix some overflow issues
>   because most users simply didn't check the overflow for the vmalloc
>   fallback.
>
> Cc: Martin Schwidefsky <[email protected]>
> Cc: Heiko Carstens <[email protected]>
> Cc: Herbert Xu <[email protected]>
> Cc: Anton Vorontsov <[email protected]>
> Cc: Colin Cross <[email protected]>
> Cc: Kees Cook <[email protected]>
> Cc: Tony Luck <[email protected]>
> Cc: "Rafael J. Wysocki" <[email protected]>
> Cc: Ben Skeggs <[email protected]>
> Cc: Kent Overstreet <[email protected]>
> Cc: Santosh Raspatur <[email protected]>
> Cc: Hariprasad S <[email protected]>
> Cc: Yishai Hadas <[email protected]>
> Cc: Oleg Drokin <[email protected]>
> Cc: "Yan, Zheng" <[email protected]>
> Cc: Alexander Viro <[email protected]>
> Cc: Alexei Starovoitov <[email protected]>
> Cc: Eric Dumazet <[email protected]>
> Cc: [email protected]
> Acked-by: Andreas Dilger <[email protected]> # Lustre
> Reviewed-by: Boris Ostrovsky <[email protected]> # Xen bits
> Acked-by: Christian Borntraeger <[email protected]> # KVM/s390
> Acked-by: Dan Williams <[email protected]> # nvdim
> Acked-by: David Sterba <[email protected]> # btrfs
> Acked-by: Ilya Dryomov <[email protected]> # Ceph
> Acked-by: Tariq Toukan <[email protected]> # mlx4
> Signed-off-by: Michal Hocko <[email protected]>

Acked-by: Leon Romanovsky <[email protected]> # mlx5

Attachment: signature.asc
Description: PGP signature

Reply via email to