From: Andreas Schultz <aschu...@tpip.net> Date: Thu, 26 Jan 2017 16:11:34 +0100
> The use of the passed through netlink src_net to check for a > cross netns operation was wrong. Using the GTP socket and the > GTP netdevice is always correct (even if the netdev has been > moved to new netns after link creation). > > Remove the now obsolete net field from gtp_dev. > > Signed-off-by: Andreas Schultz <aschu...@tpip.net> Please at least compile test your submissions: drivers/net/gtp.c: In function ‘gtp_newlink’: drivers/net/gtp.c:677:8: error: too many arguments to function ‘gtp_encap_enable’ err = gtp_encap_enable(dev, gtp, fd0, fd1, src_net); ^ drivers/net/gtp.c:659:12: note: declared here static int gtp_encap_enable(struct net_device *dev, struct gtp_dev *gtp, ^ drivers/net/gtp.c: At top level: drivers/net/gtp.c:822:12: error: conflicting types for ‘gtp_encap_enable’ static int gtp_encap_enable(struct net_device *dev, struct gtp_dev *gtp, ^ drivers/net/gtp.c:659:12: note: previous declaration of ‘gtp_encap_enable’ was here static int gtp_encap_enable(struct net_device *dev, struct gtp_dev *gtp, ^ drivers/net/gtp.c:659:12: warning: ‘gtp_encap_enable’ used but never defined drivers/net/gtp.c:822:12: warning: ‘gtp_encap_enable’ defined but not used [-Wunused-function] static int gtp_encap_enable(struct net_device *dev, struct gtp_dev *gtp, ^ scripts/Makefile.build:299: recipe for target 'drivers/net/gtp.o' failed