> I remove the word "Switch" from the commit message and phy name. > The rest is okay?
Yes. > What is generally being done when to phy's have the same id, micrel > have done this many times... It should not be a problem. When you write a switch driver for the switch, it will be in device tree. Look at the Marvell Switches as an example. Switches don't probe based on the ID in registers 2 and 3, because switches often respond to many different addresses, or don't have an ID in register 2 and 3. So it should not matter if the switch and the PHYs embedded in the switch have the same ID. When do you plan to post your switch driver? Andrew