From: Tom Herbert <t...@herbertland.com> Date: Mon, 23 Jan 2017 15:56:58 -0800
> One other potential problem in the driver is the use of put_page in > release pages. Comparing how the allocation is done in other drivers > (for instance comparing to ixgbe) some seem to use __free_pages instead. > I don't know which is correct to use, but somehow it doesn't seem like > they can both be right. The only difference I can see is that put_page() does a __page_cache_release() which shouldn't be necessary for driver RX pages, so it could be unnecessary overhead.