On Wed, Dec 21, 2016 at 03:41:58AM -0800, Selvin Xavier wrote:
> Implements add GID, del GID,  get_netdev and pkey related verbs.
>
> v3: Fixes some sparse warning related to endianness check. Removes
>     macros which are just wrapper for standard defines.
>
> Signed-off-by: Eddie Wai <eddie....@broadcom.com>
> Signed-off-by: Devesh Sharma <devesh.sha...@broadcom.com>
> Signed-off-by: Somnath Kotur <somnath.ko...@broadcom.com>
> Signed-off-by: Sriharsha Basavapatna <sriharsha.basavapa...@broadcom.com>
> Signed-off-by: Selvin Xavier <selvin.xav...@broadcom.com>
> ---
>  drivers/infiniband/hw/bnxt_re/ib_verbs.c  | 123 +++++++++++++++++
>  drivers/infiniband/hw/bnxt_re/ib_verbs.h  |  18 +++
>  drivers/infiniband/hw/bnxt_re/main.c      |   7 +
>  drivers/infiniband/hw/bnxt_re/qplib_res.c |   5 +
>  drivers/infiniband/hw/bnxt_re/qplib_res.h |   3 +
>  drivers/infiniband/hw/bnxt_re/qplib_sp.c  | 218 
> ++++++++++++++++++++++++++++++
>  drivers/infiniband/hw/bnxt_re/qplib_sp.h  |  11 ++
>  7 files changed, 385 insertions(+)
>

<snip>

> +
> +int bnxt_qplib_del_sgid(struct bnxt_qplib_sgid_tbl *sgid_tbl,
> +                     struct bnxt_qplib_gid *gid, bool update)
> +{
> +     struct bnxt_qplib_res *res = to_bnxt_qplib(sgid_tbl,
> +                                                struct bnxt_qplib_res,
> +                                                sgid_tbl);
> +     struct bnxt_qplib_rcfw *rcfw = res->rcfw;
> +     int index;
> +
> +     if (!sgid_tbl) {
> +             dev_err(&res->pdev->dev, "QPLIB: SGID table not allocated");
> +             return -EINVAL;
> +     }
> +     /* Do we need a sgid_lock here? */

It is better to answer on this question before acceptance.

> +     if (!sgid_tbl->active) {
> +             dev_err(&res->pdev->dev,
> +                     "QPLIB: SGID table has no active entries");
> +             return -ENOMEM;
> +     }

Attachment: signature.asc
Description: PGP signature

Reply via email to