> -----Original Message-----
> From: Eric Dumazet [mailto:eric.duma...@gmail.com]
> Sent: Friday, January 06, 2017 3:16 PM
> To: Grandhi, Sainath <sainath.gran...@intel.com>
> Cc: netdev@vger.kernel.org; da...@davemloft.net;
> mah...@bandewar.net; linux-ker...@vger.kernel.org
> Subject: Re: [PATCHv1 5/7] TAP: Extending tap device create/destroy APIs
>
> On Fri, 2017-01-06 at 14:33 -0800, Sainath Grandhi wrote:
>
> > +static int tap_list_add(dev_t major, const char *device_name) {
> > + int err = 0;
> > + struct major_info *tap_major;
> > +
> > + tap_major = kzalloc(sizeof(*tap_major), GFP_ATOMIC);
> > +
> > + tap_major->major = MAJOR(major);
> > +
>
>
> kzalloc() can perfectly return NULL.
>
> You do not want to crash it that happens.
>
Thanks for pointing out. Will send out next version that takes care of null
pointer
