From: [EMAIL PROTECTED]
Date: Sun, 25 Jun 2006 01:47:30 -0700

> The netpoll system currently has a rx to tx path via:
> 
> netpoll_rx
>  __netpoll_rx
>   arp_reply
>    netpoll_send_skb
>     dev->hard_start_tx
> 
> This rx->tx loop places network drivers at risk of inadvertently causing a
> deadlock or BUG halt by recursively trying to acquire a spinlock that is
> used in both their rx and tx paths (this problem was origionally reported
> to me in the 3c59x driver, which shares a spinlock between the
> boomerang_interrupt and boomerang_start_xmit routines).
> 
> This patch breaks this loop, by queueing arp frames, so that they can be
> responded to after all receive operations have been completed.  Tested by
> myself and the reported with successful results.
> 
> Specifically it was tested with netdump.  Heres the BZ with details:
> https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=194055
> 
> Signed-off-by: Neil Horman <[EMAIL PROTECTED]>
> Acked-by: Matt Mackall <[EMAIL PROTECTED]>
> Cc: "David S. Miller" <[EMAIL PROTECTED]>
> Signed-off-by: Andrew Morton <[EMAIL PROTECTED]>

Applied, thanks.
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to