Re: [PATCH net-next 1/2] phy: marvell: Add support for temperature sensor

[Sergei Shtylyov]

Hello!

On 01/11/2017 06:09 PM, Andrew Lunn wrote:

+static int marvell_hwmon_probe(struct phy_device *phydev,
+                              const struct hwmon_chip_info *chip)
+{
+       struct marvell_priv *priv = phydev->priv;
+       struct device *dev = &phydev->mdio.dev;
+       int err;
+
+       err = marvell_hwmon_name(phydev);
+       if (err)
+               return err;
+
+       priv->hwmon_dev = devm_hwmon_device_register_with_info(
+               dev, priv->hwmon_name, phydev, chip, NULL);
+
+       if (IS_ERR(priv->hwmon_dev))
+               return PTR_ERR(priv->hwmon_dev);
+
+       return 0;
+}

0-day has pointed out this can be simplified to just

        return PTR_ERR(priv->hwmon_dev);

   PTR_ERR_OR_ZERO() maybe?

[...]

MBR, Sergei