On Fri, 2006-06-23 at 13:26 -0700, David Miller wrote:
> From: Steve Wise <[EMAIL PROTECTED]>
> Date: Fri, 23 Jun 2006 15:19:28 -0500
> 
> > +struct netevent_route_change {
> > +        int event;
> > +        struct fib_info *fib_info;
> > +};
> 
> It's not generic if you're putting ipv4 FIB route objects
> in the datastructure.
> 
> This is so much unnecessary syntactic sugar for what you're
> trying to accomplish.
> 
> Just pass a "void *", and have the type of the object defined by which
> notifier it is.  This is exactly how all notifiers work today.
> 
> Then you don't need any new infrastructure at all.  The existing
> notifier bits handle this kind of scheme already, no need to
> invent new stuff.

Ok.  

But what about the redirect event?  It really needs to pass two bits of
info:  The old dst_entry ptr and the new dst_entry ptr.  This is needed
so the rdma driver can figure out which connections now need to use the
new dst_entry...




-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to