From: David Ahern <d...@cumulusnetworks.com>
Date: Sat,  7 Jan 2017 20:04:23 -0800

> Nothing about the route lookup requires bottom half to be disabled.
> Remove the local_bh_disable ... local_bh_enable around ip_route_input.
> This appears to be a vestige of days gone by as it has been there
> since the beginning of git time.
> 
> Signed-off-by: David Ahern <d...@cumulusnetworks.com>

Agreed, this shouldn't be necessary.

The key with input route lookups is that the skb->dst reference cannot
escape the packet receive path, unless we force the dst, which
ip_route_input() does under RCU protection.

So this should all be ok.

Applied, thanks.

Reply via email to