On Mon, Jan 9, 2017 at 7:04 AM, Jesper Dangaard Brouer <bro...@redhat.com> wrote: > This reverts commit 9a99d4a50cb8 ("icmp: avoid allocating large struct > on stack"), because struct icmp_bxm no really a large struct, and > allocating and free of this small 112 bytes hurts performance.
The original commit fixes a warning for large stack usage, icmp_send() is deep in the call stack. Your optimization for a slow path makes no sense to me.